Skip to content

Properly handle u8 pointers when assigning and comparing #8818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcspr merged 4 commits into from
Jan 20, 2023
Merged

Properly handle u8 pointers when assigning and comparing #8818

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3134535
IPAddress u8 vs u32 fixes
mcspr Jan 18, 2023
853dcb4
Turns out this is Arduino API
mcspr Jan 18, 2023
8ed2880
fixup! Turns out this is Arduino API
mcspr Jan 18, 2023
553e5c9
also allow unaligned copies while we are here
mcspr Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
also allow unaligned copies while we are here
  • Loading branch information
@mcspr
mcspr committed Jan 20, 2023
commit 553e5c99b007926f7975f5d3c1929d47db122b8a
4 changes: 2 additions & 2 deletions cores/esp8266/IPAddress.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ bool IPAddress::fromString4(const char *address) {

IPAddress& IPAddress::operator=(const uint8_t *address) {
uint32_t value;
std::memcpy(&value, address, sizeof(value));
memcpy_P(&value, address, sizeof(value));

*this = value;
return *this;
Expand All @@ -125,7 +125,7 @@ bool IPAddress::operator==(const uint8_t* addr) const {
}

uint32_t value;
std::memcpy(&value, addr, sizeof(value));
memcpy_P(&value, addr, sizeof(value));

return v4() == value;
}
Expand Down