Skip to content

feat(ledc): Allow attaching multiple pins to 1 channel #10032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
me-no-dev merged 10 commits into from
Jul 16, 2024
Merged

feat(ledc): Allow attaching multiple pins to 1 channel #10032

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b68bfd8
feat(ledc): Allow attaching multiple pins to 1 channel
P-R-O-C-H-Y Jul 15, 2024
477527d
feat(ledc): Add ledcWriteChannel function
P-R-O-C-H-Y Jul 15, 2024
19c6500
feat(ledc): Print info about already set channel
P-R-O-C-H-Y Jul 15, 2024
3fc241d
docs(ledc): Add ledcWriteChannel function and attach update
P-R-O-C-H-Y Jul 15, 2024
297f132
feat(ledc): Add example and fixes
P-R-O-C-H-Y Jul 15, 2024
ef1e0d3
Merge branch 'master' into feat/ledc-multiple-pins-single-channel
P-R-O-C-H-Y Jul 15, 2024
7bbdb4e
feat(ledc): Remove commented code
P-R-O-C-H-Y Jul 15, 2024
077419d
Merge branch 'feat/ledc-multiple-pins-single-channel' of https://gith…
P-R-O-C-H-Y Jul 15, 2024
bc694ce
feat(ledc): Fix missing new line at end of file
P-R-O-C-H-Y Jul 15, 2024
4dbde96
ci(pre-commit): Apply automatic fixes
pre-commit-ci-lite[bot] Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(ledc): Remove commented code
  • Loading branch information
@P-R-O-C-H-Y
P-R-O-C-H-Y committed Jul 15, 2024
commit 7bbdb4e582997861ef4d219782c6efce6486d204
2 changes: 1 addition & 1 deletion cores/esp32/esp32-hal-ledc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ static bool ledcDetachBus(void *bus) {
}

bool ledcAttachChannel(uint8_t pin, uint32_t freq, uint8_t resolution, uint8_t channel) {
if (channel >= LEDC_CHANNELS) { //|| ledc_handle.used_channels & (1UL << channel)) {
if (channel >= LEDC_CHANNELS) {
log_e("Channel %u is not available (maximum %u)!", channel, LEDC_CHANNELS);
return false;
}
Expand Down