Skip to content

fix uart_flush() returning early #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2018
Merged

fix uart_flush() returning early #2029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix uart TX flushing 
wait for FSM to return idle
  • Loading branch information
@bertmelis
bertmelis authored Nov 7, 2018
commit 369f97c8241872c1a568f39665632077f5105119
2 changes: 1 addition & 1 deletion cores/esp32/esp32-hal-uart.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ void uartFlush(uart_t* uart)
}

UART_MUTEX_LOCK();
while(uart->dev->status.txfifo_cnt);
while(uart->dev->status.txfifo_cnt || uart->dev->status.st_utx_out);

//Due to hardware issue, we can not use fifo_rst to reset uart fifo.
//See description about UART_TXFIFO_RST and UART_RXFIFO_RST in <<esp32_technical_reference_manual>> v2.6 or later.
Expand Down