mdns: Decouple networking from the main mdns module #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cermak
force-pushed
the
mdns/isolate_networking
branch
from
f64b383 to
1a37f7b
Compare
|
|
david-cermak
changed the title
david-cermak
force-pushed
the
mdns/isolate_networking
branch
from
1a37f7b to
cade052
Compare
|
@antmak PTAL |
gabsuren
approved these changes
Feb 28, 2023
|
@david-cermak LGTM, thanks |
Removed sharing the data via the global variable `_mdns_server`, added API `mdns_is_netif_ready()`
david-cermak
force-pushed
the
mdns/isolate_networking
branch
from
cade052 to
ee9b04f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple mdns.c from mdns_networking...c, so the networking part could be exported as a library and the main module could be rewritten in high(er) level language.