fix(mdns): Fix memory issues reported by valgrind

components/mdns/CMakeLists.txt

@@ -6,7 +6,7 @@ endif()
 
 idf_build_get_property(target IDF_TARGET)
 if(${target} STREQUAL "linux")
-    set(dependencies esp_event esp_netif_linux esp_timer_linux esp_system)
+    set(dependencies esp_netif_linux esp_timer_linux esp_system)
     set(srcs "mdns.c" ${MDNS_NETWORKING})
 else()
     set(dependencies lwip console esp_netif)

components/mdns/mdns.c

@@ -678,7 +678,7 @@ static uint16_t append_fqdn_dots(uint8_t *packet, uint16_t *index, const char *n
     char *end = host;
     char *start = host;
     do  {
-        end = memchr(start, '.', len);
+        end = memchr(start, '.', host + len - start);
         end = end ? end : host + len;
         int part_len = end - start;
         if (!append_single_str(packet, index, start, part_len)) {
@@ -733,6 +733,7 @@ static uint16_t _mdns_append_fqdn(uint8_t *packet, uint16_t *index, const char *
         //read the destination into name and compare
         name.parts = 0;
         name.sub = 0;
+        name.invalid = false;
         name.host[0] = 0;
         name.service[0] = 0;
         name.proto[0] = 0;

components/mdns/tests/host_test/CMakeLists.txt

@@ -5,3 +5,7 @@ set(EXTRA_COMPONENT_DIRS "../..")
 include($ENV{IDF_PATH}/tools/cmake/project.cmake)
 set(COMPONENTS main esp_netif_linux)
 project(mdns_host)
+
+# Enable sanitizers for mdns implementation
+idf_component_get_property(mdns mdns COMPONENT_LIB)
+target_link_options(${mdns} INTERFACE -fsanitize=address -fsanitize=undefined)

components/mdns/tests/host_test/components/esp_netif_linux/CMakeLists.txt

@@ -1,3 +1,2 @@
 idf_component_register(SRCS esp_netif_linux.c
-                       INCLUDE_DIRS include $ENV{IDF_PATH}/components/esp_netif/include
-                       REQUIRES esp_event)
+                       INCLUDE_DIRS include $ENV{IDF_PATH}/components/esp_netif/include)

components/mdns/tests/host_test/components/esp_netif_linux/esp_netif_linux.c

@@ -55,6 +55,7 @@ esp_err_t esp_netif_get_ip_info(esp_netif_t *esp_netif, esp_netif_ip_info_t *ip_
         }
         tmp = tmp->ifa_next;
     }
+    freeifaddrs(addrs);
     return ESP_OK;
 }
 

components/mdns/tests/host_test/components/esp_timer_linux/CMakeLists.txt

@@ -1,6 +1,5 @@
 idf_component_register(SRCS esp_timer_linux.c timer_task.cpp
-                       INCLUDE_DIRS include
-                       REQUIRES esp_event)
+                       INCLUDE_DIRS include)
 
 set_target_properties(${COMPONENT_LIB} PROPERTIES
     CXX_STANDARD 17

components/mdns/tests/host_test/components/esp_timer_linux/include/esp_timer.h

@@ -7,6 +7,7 @@
 
 #include <stdbool.h>
 #include <stdint.h>
+#include "bsd/string.h"
 
 typedef struct esp_timer *esp_timer_handle_t;