-
Notifications
You must be signed in to change notification settings - Fork 171
ci(common): Ignore ethernet warning #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e7079d1
to
df6e7f3
Compare
strategy: | ||
matrix: | ||
idf_ver: ["release-v5.0", "release-v5.1", "release-v5.2", "release-v5.3", "latest"] | ||
idf_ver: ["latest"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep the active IDF releases. at least for the build steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. @glmfe , could you please clarify what's the reason for removing it from the running step as well? Is this a temporary change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need to keep all of them before merging. I only removed them to get a quick result from the CI, since esptool is failing when running on 'latest' and I couldn’t test it locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted 😄
ac3b101
to
4104136
Compare
4104136
to
a96be89
Compare
- Currently the "latest" docker image is outdated causing some warnings regarding the eth driver configs.
a96be89
to
0c297fe
Compare
Description