Improve schema limits #1157
Merged
Improve schema limits #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `flowctl-go serve consumer`
jshearer
force-pushed
the
fix/improve_schema_limits
branch
from
7d6d596 to
8166b31
Compare
Member
jgraettinger
left a comment
jgraettinger
left a comment
There was a problem hiding this comment.
A few comments, looking good!
…ditional* properties
…ms`) from a child immediately prior to smooshing into a parent
jgraettinger
approved these changes
Aug 24, 2023
crates/doc/src/shape/limits.rs
Outdated
| for prop in slf.object.properties.iter_mut() { | ||
| enforce_field_count_limits(&mut prop.shape, loc.push_prop(&prop.name)) | ||
| shape_to_squash.array.additional_items = | ||
| squash_addl_properties(shape_to_squash.array.additional_items); |
Member
There was a problem hiding this comment.
can't you just set additional_items and additional_properties to None ?
nit: if you can't and must keep this, then squash_addl_properties => squash_addl ? sometimes item, sometimes property
jshearer
force-pushed
the
fix/improve_schema_limits
branch
from
ba809e8 to
8b7196c
Compare
jshearer
force-pushed
the
fix/improve_schema_limits
branch
from
8b7196c to
441ea5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
--flow.enable-schema-inferenceflag toflowctl-go serve consumerto enable schema inference for capture tasksThis change is