Skip to content

Conversation

@jshearer
Copy link
Contributor

@jshearer jshearer commented Sep 3, 2025

Description:

Fixes a small but important mistake in #2358, namely that this actually does not work as a way to get a metadata response from the broker in order to fetch the write head of a journal:

broker::ReadRequest {
    journal: partition.spec.name.clone(),
    offset: -1,
    ..Default::default()
};

Instead, the proper incantation is

broker::ReadRequest {
    journal: partition.spec.name.clone(),
    offset: 0,
    metadata_only: true,
    ..Default::default()
};

Tested locally and on dekaf-dev, confirmed this now doesn't error when fetching offsets with a timestamp of -1.

$ kcat -o beginning  -b dekaf-dev.estuary-data.com:9092 \                                                                                                                                                                                                                                                                   
-X security.protocol=SASL_SSL \
-X sasl.mechanism=PLAIN \
-Q -t "events:0:-1"
events [0] offset 414002872

This change is Reviewable

@jshearer jshearer marked this pull request as ready for review September 3, 2025 21:29
Copy link
Member

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jshearer jshearer merged commit a65a5cf into master Sep 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants