More changes from review of bot api 6.6 #1952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Looks like that's all from my previous review... |
coder2020official
requested changes
Mar 25, 2023
Collaborator
coder2020official
left a comment
coder2020official
left a comment
There was a problem hiding this comment.
Nice job!
Tip: you can press commit button on my suggestions.
Co-authored-by: _run <[email protected]>
Co-authored-by: _run <[email protected]>
Co-authored-by: _run <[email protected]>
Co-authored-by: _run <[email protected]>
Co-authored-by: _run <[email protected]>
Co-authored-by: _run <[email protected]>
Co-authored-by: _run <[email protected]>
Co-authored-by: _run <[email protected]>
Collaborator
|
Forgot about indentation.. can you correct indentation of descriptions? |
Collaborator
|
This is the last thing ig, otherwise LGTM |
Collaborator
Author
Done |
telebot/__init__.py
Outdated
| :type message_thread_id: :obj:`int` | ||
| :param thumb: Deprecated. Use thumbnail instead | ||
Collaborator
There was a problem hiding this comment.
Suggested change
| :type thumb: :obj:`str` or :class:`telebot.types.InputFile` |
Collaborator
|
|
Co-authored-by: _run <[email protected]>
Collaborator
|
one commit left |
Collaborator
Author
|
|
Collaborator
Author
|
This PR lives too long. I'll merge, add your commit in another PR if you want to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typo and thub fixes.