Skip to content

New testtttt #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

New testtttt #1475

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9fc42e5
testing
krofax Mar 6, 2025
333c337
fix nextra
krofax Mar 6, 2025
16e768c
updated lock file
krofax Mar 6, 2025
daeec8b
fix merge conflict
krofax Mar 6, 2025
fda10d5
updated lockfile
krofax Mar 6, 2025
7b16cf7
update netlify build
krofax Mar 6, 2025
f3ddcdf
updated the lock
krofax Mar 6, 2025
0752d5f
remove breadcrumbs
krofax Mar 6, 2025
1befd17
updated the husky file
krofax Mar 6, 2025
dbd4b91
updated husky
krofax Mar 6, 2025
29d1343
updated the husky commands to accommodate GH
krofax Mar 6, 2025
9aeefea
updated husky commands
krofax Mar 6, 2025
6a8e3e9
test commit
bradleycamacho Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update netlify build
  • Loading branch information
@krofax
krofax committed Mar 6, 2025
commit 7b16cf7aa798d990a49acbd8645448710c2b273b
8 changes: 6 additions & 2 deletions netlify.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
[build]
command = "pnpm install --no-frozen-lockfile && pnpm build"
publish = ".next"

[build.environment]
PNPM_VERSION = "10.2.0"
NODE_VERSION = "20.11.0"
NODE_VERSION = "20.11.0"
NPM_FLAGS = "--no-frozen-lockfile"
Comment on lines +6 to +7
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Ensure consistent Node version across environments

The specified Node version (20.11.0) should be consistent with other environments. Also, the NPM_FLAGS setting with --no-frozen-lockfile aligns with the CircleCI configuration, which is good for consistency.

🏁 Script executed:

#!/bin/bash
# Check for Node version specifications across different configuration files
echo "Checking Node version specifications:"
grep -r "node" --include="*.yml" --include="*.json" --include="Dockerfile" . | grep -E "version|image"

Length of output: 284

Align Node Versions Between Netlify and CircleCI

  • File: netlify.toml (Lines 6-7)
    The configuration currently specifies:

      NODE_VERSION = "20.11.0"
  NPM_FLAGS = "--no-frozen-lockfile"

  • File: .circleci/config.yml
    The Node image is set as:

        - image: cimg/node:20.11.1 # Prebuilt CircleCI image for Node.js 20.x

To ensure consistency across environments, please update the Node version in netlify.toml to match the version used in the CircleCI configuration (i.e., update from "20.11.0" to "20.11.1"), unless there is a specific reason for the discrepancy.