-
Notifications
You must be signed in to change notification settings - Fork 266
revise node overview #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revise node overview #694
Conversation
cpengilly
commented
May 16, 2024
- replace node overview with node rollup for the superchain guide
- update links and redirects
- address previous feedback
- replace node overview with node rollup for the superchain guide - update links and redirects - address previous feedback
WalkthroughThe recent updates aim to streamline and improve the documentation for running OP Mainnet nodes. Changes include updating links to the new "Node Operator" guide, refining JSON key names for better clarity, and introducing a comprehensive guide on running a rollup node within the Superchain. These adjustments are geared towards enhancing user experience by providing more precise and accessible information. Changes
Recent Review DetailsConfiguration used: .coderabbit.yaml Files selected for processing (2)
Files not reviewed due to errors (1)
Files skipped from review due to trivial changes (1)
Additional Context UsedLanguageTool (2)
Path-based Instructions (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
Out of diff range and nitpick comments (7)
pages/index.mdx (2)
Line range hint
16-16
: Use "an" instead of "a" before a word starting with a vowel sound.- Whether you're a developer building a app on OP Mainnet, + Whether you're a developer building an app on OP Mainnet,
Line range hint
32-32
: Consider using a more formal and expressive alternative to "amazing".- Check out these amazing tools, so you can get building with Optimism. + Check out these excellent tools, so you can get building with Optimism.pages/builders/cex-wallet-developers/wallet-support.mdx (1)
Line range hint
11-11
: Avoid split infinitives by moving the adverb.- to properly support OP Mainnet within your wallet. + to support OP Mainnet properly within your wallet.pages/chain/networks.mdx (2)
Line range hint
32-32
: Consider using the past participle "written" for clarity.- The sequencer URL is write only. + The sequencer URL is write-only.
Line range hint
48-48
: Consider using the past participle "written" for clarity.- The sequencer URL is write only. + The sequencer URL is write-only.pages/builders/cex-wallet-developers/cex-support.mdx (1)
Line range hint
11-11
: Avoid split infinitives by moving the adverb.- to properly support OP Mainnet within your exchange. + to support OP Mainnet properly within your exchange.pages/connect/contribute/style-guide.mdx (1)
Line range hint
362-362
: Fix the grammatical error.- It's value lies in its simplicity and ability to speed up onboarding (e.g., installation, deployment, etc.) and developers' first steps, thus improving the developer experience. + Its value lies in its simplicity and ability to speed up onboarding (e.g., installation, deployment, etc.) and developers' first steps, thus improving the developer experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm