Skip to content

Add EIP: Revert creation in case of non-empty storage #8161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eth-bot merged 6 commits into from
Apr 8, 2024
Merged

Add EIP: Revert creation in case of non-empty storage #8161

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
70ecb8f
Add EIP: Revert creation in case of non-empty storage
rjl493456442 Feb 2, 2024
29c83f6
Add ethereum-magicians link
rjl493456442 Feb 2, 2024
bdfd33b
fix format
rjl493456442 Feb 2, 2024
8903f82
Assign EIP number
rjl493456442 Feb 2, 2024
797f08d
Update EIPS/eip-7610.md
rjl493456442 Apr 2, 2024
cf2e790
Update EIPS/eip-7610.md
rjl493456442 Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update EIPS/eip-7610.md 
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
  • Loading branch information
@rjl493456442 @SamWilsn
rjl493456442 and SamWilsn authored Apr 2, 2024
commit cf2e790d0588b0d7571eb518a28e6c211f1f0f81
2 changes: 1 addition & 1 deletion EIPS/eip-7610.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ This is an execution layer upgrade, and so it requires a hard fork.

## Test Cases

There exists quite a number of tests in the ethereum tests repo aswell as in the execution spec tests, which test the scenario of deployment to targets with non-empty storage. These tests have been considered problematic in the past; Reth and EELS both intentionally implement a version of the account reset solely to pass the tests. Py-evm declared the situation impossible and never implemented account reset.
There exists quite a number of tests in the ethereum tests repo as well as in the execution spec tests, which test the scenario of deployment to targets with non-empty storage. These tests have been considered problematic in the past; Reth and EELS both intentionally implement a version of the account reset solely to pass the tests. Py-evm declared the situation impossible and never implemented account reset.

Refilling the existing tests will provide sufficient coverage for this EIP.

Expand Down