Skip to content
This repository was archived by the owner on Oct 28, 2021. It is now read-only.

JSON-RPC #382

Merged
gavofyork merged 121 commits into from
Oct 31, 2014
Merged

JSON-RPC #382

gavofyork merged 121 commits into from
Oct 31, 2014

Conversation

@debris
Copy link
Contributor

@debris debris commented Oct 16, 2014

Changes made in this pull-request:

  • jsonrpc api with all methods available from javascript-api
  • added cors headers to jsonrpc
  • separated libethrpc
  • Javascript jsonrpc client, with the same interface as Javascript bindings in EthereumBrowser, so there is now possibility to run/debug code using eth object in Chrome/Firefox and other browsers
  • here is a playground - https://github.com/debris/eth-client-example
  • added async setters/getters for javascript properties
  • tests for most of jsonrpc methods
  • api is not yet unified with Go client api

debris added 30 commits October 11, 2014 00:59
@debris
jsonrpc refactor in progress
770d6f9
@debris
new abstractstub && before changes
b970673
@debris
jsonrpcstubs in progres
e4dd2c0
@debris
jsonrpc in progress
00bbca9
@debris
jsonrpc in progress
dd41908
@debris
few more jsonrpc methods
2c58f14
@debris
preparing for tests
1fc7e1b
@debris
ethrpc separated && first tests
3c4da0e
@debris
jsornrpc tests in progress
a378709
@debris
Merge branch 'develop' into mk_jsonrpc
4ad6113
@debris
jsonrpc tests
8816dde
@debris
corshttpserver
daa23e4
@debris
common changes
178d80d
@debris
Merge branch 'develop' into mk_jsonrpc
aa9f34e
@debris
common changes in jsonrpc && tests
008fd25
@debris
fixed jsonrpc param types
d1205fa
@debris
Merge branch 'develop' into mk_jsonrpc
d632a3a
@debris
stateless tests
cd0a1c4
@debris
common changes
1b21fa4
@debris
value in messages
83f286a
@debris
isMining changes to mining
bfb05d0
@debris
default params temporarily remode
21b5e88
@debris
setCoinbase method
18ce0e9
@debris
listening and mining param names
8ccc593
@debris
proprties of jsonrpc eth object are working like in docs
6826f08
@debris
properties access unified
57bd143
@debris
updated eth.js
3342a69
@debris
jsonrpc renaming properties in request
fbd70ac
@debris
getMessage in QEthereum made async
e645900
@debris
Merge branch 'develop' into mk_jsonrpc
acf9bdc
subtly
subtly reviewed Oct 31, 2014
View reviewed changes
alethzero/MainWin.cpp
Copy link
Member

@subtly subtly Oct 31, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

owned() returning keys+identities (see previous comment)

subtly
subtly reviewed Oct 31, 2014
View reviewed changes
third/MainWin.cpp Outdated
Copy link
Member

@subtly subtly Oct 31, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where m_qwebConnector is deallocated. I don't think m_qwebConnector should be a pointer. If it's no longer a pointer, then It can also be initialized in the constructor.

Copy link
Contributor Author

@debris debris Oct 31, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 8c6af7f

gavofyork pushed a commit that referenced this pull request Oct 31, 2014
Merge pull request #382 from debris/mk_jsonrpc
205a464 
JSON-RPC
@gavofyork gavofyork merged commit 205a464 into ethereum:develop Oct 31, 2014
@debris debris mentioned this pull request Oct 31, 2014
Closed
@debris debris deleted the mk_jsonrpc branch November 12, 2014 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@debris @caktux @gavofyork @subtly @nicksavers