Remove signHash in favor of unsafe_sign_hash #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
unsafe-sign-hash
branch
from
5f96177 to
10bdd06
Compare
kclowes
force-pushed
the
unsafe-sign-hash
branch
from
c3c452e to
9bb3ad6
Compare
fselmo
reviewed
Apr 3, 2024
Contributor
fselmo
left a comment
fselmo
left a comment
There was a problem hiding this comment.
lgtm. I think the name change should point most users to reading the documentation.
3 tasks
3 tasks
|
Sounds like a really good solution, thanks @kclowes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
It's not safe to sign random hashes, but occasionally developers want to do so. We were undecided about what to do with the method, but decided to add a new method called
unsafe_sign_hashand finally removesignHashCloses #85
How was it fixed?
Removed
signHash, moved functionality tounsafe_sign_hash.LMK if you think we should add more/different docs
Todo:
Clean up commit history
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture