feat: add AssetDownload component stories for Storybook #16260
+38
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahendraBishnoi29
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kmk142789
approved these changes
Sep 14, 2025
wackerow
requested changes
Sep 15, 2025
There was a problem hiding this comment.
Hey @MahendraBishnoi29, thanks for this! Getting this error on each of these when viewing locally: Path must be a string. Received null
Small house-keeping note as well, if you use the words "Closes" or "Fixes" before the issue number in your PR description it will properly link it to that issue, so the issue is auto-closed when the PR is merged. And bonus, if it's used with a bullet-point, GitHub will render it nicely with the issue title and status as well:
## Related Issue
- Closes #13045
I've gone ahead and updated this, but just noting for your sake =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The two stories I created,
WithArtistandBrandAsset, are designed to reflect the primary ways theAssetDownloadcomponent is used on our current assets page.These stories test the component's rendering in the main contexts you're using it in.
Related Issue