-
Notifications
You must be signed in to change notification settings - Fork 5.2k
rearranged page to fit upcoming blog post structure, added non-core EIPs #16298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…IPs, restructured links a little
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the updates @nixorokish, left some house-keeping suggestions then can get this pulled in.
Specification: https://eips.ethereum.org/EIPS/eip-7594 | ||
|
||
Resources: https://youtu.be/bONWd1x2TjQ?t=328 (dapplion on PeerDAS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also noting that @taxmeifyoucan also just put up content updates to this page linking out to this new PeerDAS page in #16296...
Not super picky where exactly we link to this, but would try to find one place for it. In that PR it was just placed as a raw URL next to this "Resources" line, and I had suggested moving it to it's own callout at the end of this section, which I see a similar approach below (just wouldn't duplicate links within a given page).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much for the thorough review @wackerow !! moved the link to the bottom per your suggestion & also resolved the other comments
Co-authored-by: wackerow <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin good.. Couple small tiny nit-picks 🙏, then can get this in (alt text on the image diagram please)
@@ -44,11 +43,15 @@ These coordinated upgrades generally include a lot of changes, require a lot of | |||
|
|||
Blob parameter only forks can be set by clients, similarly to other configuration like gas limit. Between major Ethereum upgrades, clients can agree to increase the `target` and `max` blobs to e.g. 9 and 12 and then node operators will update to take part in that tiny fork. These blob parameter only forks can be configured at any time. | |||
|
|||
#### Blob base-fee bounded by execution costs {#blob-base-fee-bounded-by-execution-costs} | |||
When blobs were first added to the network in the Dencun upgrade, the target was 3 - that was increased to 6 in Pectra and, after Fusaka, that can now be increased at a sustainable rate independently of these major network upgrades. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(refs: https://www.merriam-webster.com/grammar/em-dash-en-dash-how-to-use and https://www.grammarbook.com/numbers/numbers.asp)
Nit-pick but since we're using numerals for small digits already in other places, would just hard-stop the first sentence here:
When blobs were first added to the network in the Dencun upgrade, the target was 3 - that was increased to 6 in Pectra and, after Fusaka, that can now be increased at a sustainable rate independently of these major network upgrades. | |
When blobs were first added to the network in the Dencun upgrade, the target was 3. That was increased to 6 in Pectra and, after Fusaka, that can now be increased at a sustainable rate independently of these major network upgrades. |
|
||
Specification: https://eips.ethereum.org/EIPS/eip-7892 | ||
#### Blob parameter only forks {#blob-parameter-only-forks} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed this before—commented same on #16296 but would try to match the canonical capitalization/punctuation from the EIP for consistency
#### Blob parameter only forks {#blob-parameter-only-forks} | |
#### Blob-Parameter-Only forks {#blob-parameter-only-forks} |
|
||
Specification: https://eips.ethereum.org/EIPS/eip-7918 | ||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need an alt text description here for screen readers 🙏
and restructured links a little
Description
Fusaka blog post coming soon, restructured some of the EIPs to match that so it's not confusing to audiences. ALSO PLEASE NOTE - there's an image I need attached (line 46), wasn't sure where in the file tree it needed to be, so right now it's a google drive link. Please lmk how to format correctly, thank you!
Related Issue
n/a