Fix string fragment issues #4625
Conversation
corwintines
requested review from
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
minimalsm
left a comment
minimalsm
left a comment
There was a problem hiding this comment.
Nice find on the FormattedHTMLMessage 😀
Not exactly tied to this PR but re-iterating my concern that adding a translated equivalent of the word 'yet' to languages with a potentially different sentence structure might lead to some confusion (will default to @lukassim on this).
| @@ -1,11 +1,11 @@ | |||
| import React from "react" | |||
| import { FormattedMessage } from "gatsby-plugin-intl" | |||
| import { FormattedHTMLMessage } from "gatsby-plugin-intl" | |||
| "page-tutorial-submit-tutorial": "За да публикувате урок, ще трябва да използвате GitHub. Добре дошли сте да зададете въпрос или заявка за сливане.", | ||
| "page-tutorial-subtitle": "Добре дошли в нашия подбран списък с уроци за общността.", | ||
| "page-tutorial-tags-error": "Никои от уроците нямат всички тези тагове", | ||
| "page-tutorial-tags-error": "Никои от уроците нямат всички тези тагове <b>все още</b>", |
There was a problem hiding this comment.
No biggie but for a11y I think <strong> is more semantic than <b> in this usage
| "page-tutorial-submit-btn": "Submit a tutorial", | ||
| "page-tutorial-submit-tutorial": "To submit a tutorial, you'll need to use GitHub. We welcome you to create an issue or a pull request.", | ||
| "page-tutorial-subtitle": "Welcome to our curated list of community tutorials.", | ||
| "page-tutorial-tags-error": "There are no tutorials with all your chosen tags yet", |
There was a problem hiding this comment.
| "page-tutorial-tags-error": "There are no tutorials with all your chosen tags yet", | |
| "page-tutorial-tags-error": "There are no tutorials with all your chosen tags <b>yet</b>", |
|
@minimalsm changed all the to . Thanks for review. |
|
@corwintines very welcome |
|
Dangit, didnt realize github would jsut consume that html haha |
Gatsby Cloud Build Reportethereum-org-website-dev2 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 7m PerformanceLighthouse report
|
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 7m PerformanceLighthouse report
|
This should be fine with this approach, as long as 'yet' is part of the same string as the rest of the sentence. This way, the translators can move the tags to a suitable part of the sentence. |
Fix string fragments outlined in notion card:
ethereum-org-website/src/intl/en/page-wallets-find-wallet.json
Line 132 in b412156
ethereum-org-website/src/intl/en/page-eth2-vision.json
Line 45 in 4e8f882
ethereum-org-website/src/intl/en/page-eth2-get-involved-bug-bounty.json
Line 42 in c1e1a26