Add headers to all markdown files #4627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corwintines
requested review from
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
github-actions
bot
added
content 🖋️
minimalsm
requested changes
Dec 3, 2021
Contributor
minimalsm
left a comment
minimalsm
left a comment
There was a problem hiding this comment.
Although this fixes the console errors it creates duplicate headers on these pages.
If we do need to add headers we should also probably use H2s as we already have a H1 on all tutorial pages that we pull from the title in the frontmatter.
Contributor
|
Although at a glance I don't see an immediately obvious place to put a header in this short tutorial... 🤔 Maybe just this?
|
minimalsm
requested changes
Dec 3, 2021
src/content/developers/tutorials/logging-events-smart-contracts/index.md
Outdated
Show resolved
Hide resolved
| address: "0x19dE91Af973F404EDF5B4c093983a7c6E3EC8ccE" | ||
| --- | ||
|
|
||
| # Rejestrowanie danych z inteligentnych kontraktów ze zdarzeniami {#logging-data-from-smart-contracts-with-events} |
src/content/translations/pl/developers/tutorials/logging-events-smart-contracts/index.md
Outdated
Show resolved
Hide resolved
src/content/translations/ro/developers/tutorials/logging-events-smart-contracts/index.md
Outdated
Show resolved
Hide resolved
src/content/translations/zh/developers/tutorials/logging-events-smart-contracts/index.md
Outdated
Show resolved
Hide resolved
Member
Author
|
Makes sense to me. The translation support is throwing errors for these markdown files when the regex is ran to look at headers, so needed to add a few. This will work, thanks! |
…s/index.md Co-authored-by: Joshua <[email protected]>
…s-smart-contracts/index.md Co-authored-by: Joshua <[email protected]>
…s-smart-contracts/index.md Co-authored-by: Joshua <[email protected]>
…s-smart-contracts/index.md Co-authored-by: Joshua <[email protected]>
Member
Author
|
@minimalsm merged your changes in, think this is ready for a review again |
minimalsm
approved these changes
Dec 9, 2021
wackerow
approved these changes
Dec 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes: #4622