Skip to content

Update sharding date to ~2023 #4637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wackerow merged 4 commits into from
Dec 10, 2021
Merged

Update sharding date to ~2023 #4637

wackerow merged 4 commits into from
Dec 10, 2021

Conversation

@minimalsm
Copy link
Contributor

@minimalsm minimalsm commented Dec 3, 2021

Description

Changes sharding date to ~2023 as per Trent's predictions

Related Issue

None

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 translation 🌍 This is related to our Translation Program labels Dec 3, 2021
samajammin
samajammin suggested changes Dec 5, 2021
View reviewed changes
Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

I'm noticing at least a couple other places where this is listed & still needs to be updated. Both of these are on the Eth2 homepage:
Image 2021-12-05 at 9 03 04 AM

Image 2021-12-05 at 9 02 52 AM

Please do another sweep & ensure we catch all instances.

@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 10, 2021 •
edited
Loading

Gatsby Cloud Build Report

ethereum-org-website-dev2

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 7m

Performance

Lighthouse report

Metric Score
Performance 🔶 17
Accessibility 💚 97
Best Practices 💚 93
SEO 🔶 79

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 10, 2021 •
edited
Loading

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 5m

Performance

Lighthouse report

Metric Score
Performance 🔶 13
Accessibility 💚 97
Best Practices 💚 93
SEO 🔶 79

🔗 View full report

wackerow
wackerow approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the others in the images posted above for all languages. Should be good to go now

@wackerow wackerow merged commit 1bba4c5 into dev Dec 10, 2021
@wackerow wackerow deleted the updateShardingDate branch December 10, 2021 05:06
@wackerow
Copy link
Member

wackerow commented Dec 10, 2021

Pulled in, lemme know if any more "2022" (or "2021" 😬) are spotted

@wackerow wackerow mentioned this pull request Dec 10, 2021
Merged
@minimalsm
Copy link
Contributor Author

minimalsm commented Dec 10, 2021

Sorry, never got round to this! Thanks for cleaning up @wackerow. I'll put it on my list today to double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wackerow wackerow wackerow approved these changes

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

+1 more reviewer

@samajammin samajammin samajammin requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@minimalsm @wackerow @samajammin