Sort meetup list #4662
Merged
Sort meetup list #4662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amm98d
requested review from
corwintines,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
Contributor
Author
|
Hey @samajammin, updated from random shuffling to sort by country+city. Kindly review. |
Closed
corwintines
requested changes
Dec 7, 2021
Member
corwintines
left a comment
corwintines
left a comment
There was a problem hiding this comment.
Hey @amm98d, thanks for the contribution. At the moment this wont work. You'll need to do the following.
- import lodash at the top of the file. You could even just import the sortBy method:
import { sortBy } from 'lodash' - store the sorted list in a variable:
const sortedMeetups = sortBy(meetups, ['emoji', 'location']) - use the sortedMeetups variable in the render method of this component where we map over the list of meetups. ie:
sortedMeetups.map
Contributor
Author
Understood. I followed the syntax from the documentation, my bad. Pushing changes shortly. |
minimalsm
approved these changes
Dec 8, 2021
Contributor
minimalsm
left a comment
minimalsm
left a comment
There was a problem hiding this comment.
LGTM :-) the deploy preview isn't working right now (unrelated issue) but working fine locally.
Member
|
@all-contributors please add @amm98d for code |
Contributor
|
I've put up a pull request to add @amm98d! 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a function that implements the Fisher-Yates Shuffling algorithm.
Related Issue
#4657