Render StatsBoxGrid as a span [Fixes #4757] #4779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneskj55
requested review from
corwintines,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
minimalsm
reviewed
Dec 15, 2021
minimalsm
approved these changes
Dec 15, 2021
Contributor
minimalsm
left a comment
minimalsm
left a comment
There was a problem hiding this comment.
Thanks for this @joneskj55.
Made a small tweak from px to rem in the name of accessibility while I was here :-)
Contributor
Author
|
@minimalsm Cool, and thanks for the a11y link! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renders the StatsBoxGrid result as a
spanas opposed to anh3element.Related Issue
#4757
With change