Add API tooltip to L2 page #5880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corwintines
requested review from
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
github-actions
bot
added
content 🖋️
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 16m PerformanceLighthouse report
|
minimalsm
reviewed
Apr 1, 2022
Contributor
minimalsm
left a comment
minimalsm
left a comment
There was a problem hiding this comment.
The tooltip looks good and works on all screensizes for me. Tested on my mobile too 🎉😀
src/pages/layer-2.js
Outdated
Comment on lines
243
to
244
| minimumSignificantDigits: 2, | ||
| maximumSignificantDigits: 3, | ||
| maximumSignificantDigits: 2, |
Contributor
There was a problem hiding this comment.
Currently, the 'Average layer 2 ETH transfer fee' is showing up as 1 decimal point. I was verrrry confused by this because in school, we were taught decimal places ==== significant digits. Apparently not!
Not 100% sure if this is what you're after but it looks like there is a minimumFractionDigits and maximumFractionDigits that we could use here instead to get it to display like regular currency ($1.10, in this case).
Tested a little and it seems to be working as we would expect.
wackerow
approved these changes
Apr 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description