-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add eattheblocks tutorials #637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @jklepatch! Made one comment - please remove that duplicate link.
Out of curiosity, why do you feel your additions should be at the top of each section? 😄
@CPSTL assigning to you for review.
docs/developers/index.md
Outdated
@@ -439,6 +440,13 @@ The Ethereum network is made up of many nodes who run compatible client software | |||
|
|||
### General Learning {#general-learning} | |||
|
|||
**EatTheBlocks -** **_Learn to build Ethereum Dapps & Solidity smart contracts with video tutorials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown error
@samajammin thanks for your comments I have addressed them :) |
@samajammin @CPSTL I have made the requested changes, could you guys have a last look and merge if everything looks good? :) thx |
@samajammin @CPSTL any updates on this? |
In this case, I think @jklepatch's videos being on top in the sections he added is coherent, for his content is more up to date than the previous top listed content. But we should figure out a way to order content, maybe alphabetically? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jklepatch Until we have a way to order the content, we typically ask users to add their content to the bottom of each section / list. |
@jklepatch - sorry for the delay on this. I agree with @faraggi that a discussion on ordering would be beneficial, perhaps with some way to prioritize the "freshest" content but for now, as @CPSTL mentioned, we'd like folks to add new additions to the bottom of each list to keep treatment consistent. Please make that update & we'll get this merged ASAP. Thanks! |
@jklepatch checking in. Go ahead & make those updates & we'll get this merged. Thanks! |
@samajammin just did :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
@all-contributors please add @jklepatch for content |
I've put up a pull request to add @jklepatch! 🎉 |
Added links to eattheblocks tutorials in developers ressources