Skip to content

Conversation

jklepatch
Copy link
Contributor

Added links to eattheblocks tutorials in developers ressources

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jklepatch! Made one comment - please remove that duplicate link.

Out of curiosity, why do you feel your additions should be at the top of each section? 😄

@CPSTL assigning to you for review.

@@ -439,6 +440,13 @@ The Ethereum network is made up of many nodes who run compatible client software

### General Learning {#general-learning}

**EatTheBlocks -** **_Learn to build Ethereum Dapps & Solidity smart contracts with video tutorials
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown error

@jklepatch
Copy link
Contributor Author

@samajammin thanks for your comments I have addressed them :)
As for my links being on top of each section, well its better than being at the bottom haha!
But more seriously I keep my tutorials very up-to-date and I upload new tutorial videos for ethereum developers every day on my channel EatTheBlocks.

@jklepatch
Copy link
Contributor Author

@samajammin @CPSTL I have made the requested changes, could you guys have a last look and merge if everything looks good? :) thx

@jklepatch jklepatch changed the title Added eattheblocks tutorials Add eattheblocks tutorials Jan 5, 2020
@jklepatch
Copy link
Contributor Author

@samajammin @CPSTL any updates on this?

@faraggi
Copy link
Contributor

faraggi commented Jan 7, 2020

In this case, I think @jklepatch's videos being on top in the sections he added is coherent, for his content is more up to date than the previous top listed content.

But we should figure out a way to order content, maybe alphabetically?

Copy link
Contributor

@faraggi faraggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CPSTL
Copy link
Member

CPSTL commented Jan 7, 2020

@samajammin @CPSTL any updates on this?

@jklepatch Until we have a way to order the content, we typically ask users to add their content to the bottom of each section / list.

@samajammin
Copy link
Member

@jklepatch - sorry for the delay on this. I agree with @faraggi that a discussion on ordering would be beneficial, perhaps with some way to prioritize the "freshest" content but for now, as @CPSTL mentioned, we'd like folks to add new additions to the bottom of each list to keep treatment consistent. Please make that update & we'll get this merged ASAP. Thanks!

@samajammin
Copy link
Member

@jklepatch checking in. Go ahead & make those updates & we'll get this merged. Thanks!

@jklepatch
Copy link
Contributor Author

@samajammin just did :)

Copy link
Contributor

@faraggi faraggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@CPSTL CPSTL merged commit 2880df5 into ethereum:dev Jan 21, 2020
@CPSTL
Copy link
Member

CPSTL commented Jan 21, 2020

@all-contributors please add @jklepatch for content

@allcontributors
Copy link
Contributor

@CPSTL

I've put up a pull request to add @jklepatch! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants