Skip to content

Engine API: return error if forkchoice state is inconsistent #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 10, 2022
Merged

Engine API: return error if forkchoice state is inconsistent #213

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f5e780e
Engine API: return error if forkchoice state is inconsistent
mkalinin Apr 29, 2022
e9053b6
Adjust error code with JSON-RPC spec
mkalinin May 3, 2022
cfc8374
Merge branch 'main' into invalid-forkchoice-state
mkalinin May 6, 2022
6438091
Harden forkchoice state validity condition
mkalinin May 6, 2022
02f55b2
Fix steps in forkchoiceUpdated method spec
mkalinin May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix steps in forkchoiceUpdated method spec
  • Loading branch information
@mkalinin
mkalinin committed May 6, 2022
commit 02f55b2eecdb1af053840743e2a3dc0838b93ba1
2 changes: 1 addition & 1 deletion src/engine/specification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ The payload build process is specified as follows:
* `{error: {code: -38002, message: "Invalid forkchoice state"}}` if `forkchoiceState` is either invalid or inconsistent
* `{error: {code: -38003, message: "Invalid payload attributes"}}` if the payload is deemed `VALID` and `forkchoiceState` has been applied successfully, but no build process has been started due to invalid `payloadAttributes`.

9. If any of the above fails due to errors unrelated to the normal processing flow of the method, client software **MUST** respond with an error object.
10. If any of the above fails due to errors unrelated to the normal processing flow of the method, client software **MUST** respond with an error object.

### engine_getPayloadV1

Expand Down