params: update 4844 parameters#28026
Merged
holiman merged 6 commits intoethereum:masterfrom Sep 5, 2023
Merged
Conversation
Member
Author
|
Oh we also updated the name of |
rjl493456442
approved these changes
Aug 30, 2023
holiman
approved these changes
Aug 30, 2023
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
LGTM
You had me at "makes the word blob not appear twice in a variable name"
Contributor
|
Update the test-expects too |
karalabe
reviewed
Aug 30, 2023
params/protocol_params.go
Outdated
| BlobTxPointEvaluationPrecompileGas = 50000 // Gas price for the point evaluation precompile. | ||
|
|
||
| MaxBlobGasPerBlock = 6 * BlobTxBlobGasPerBlob // Maximum consumable blob gas for data blobs per block | ||
| TargetBlobGasPerBlock = 3 * BlobTxBlobGasPerBlob // Target consumable blob gas for data blobs per block (for 1559-like pricing) |
Member
There was a problem hiding this comment.
The params is already a huge collection of completely random names stuff that you have no idea where they come from. I.e. RefundQuotient, which EIP does it belong to? Nobody knows unless you really start digging deep. The BlobTx prefix was meant to follow the Bla12381 prefix idea to group the constants into more meaningful groups, even if a bit too verbose. I'd highly recommend keeping the prefix.
Member
Author
There was a problem hiding this comment.
I can open a separate PR to adjust the naming. The change has been reverted in this PR.
jsvisa
added a commit
to jsvisa/go-ethereum
that referenced
this pull request
Sep 5, 2023
This reverts commit 25733a4. Signed-off-by: jsvisa <delweng@gmail.com>
jsvisa
added a commit
to jsvisa/go-ethereum
that referenced
this pull request
Sep 5, 2023
This reverts commit a456438. Signed-off-by: jsvisa <delweng@gmail.com>
DaniPopes
added a commit
to DaniPopes/revm
that referenced
this pull request
Sep 6, 2023
rakita
added a commit
to bluealloy/revm
that referenced
this pull request
Sep 15, 2023
* feat: point evaluation precompile * feat: BLOBHASH opcode * refactor: revme runner * renames * export global kzg settings * feat: include kzg settings bytes with `include_bytes!` * build.rs: remove second option, update docs * revme: remove unused files and dead code * feat: implement remaining block and tx env fields * Add tests for helper functions, update constants * Add EIP-4844 EF tests to CI, skip outdated ones * chore: make skip_test more readable * Fix tests * Fix fmt * Fix lints, review * fix: validate new tx, block fields; add to balance check * Restore `load_access_list` * chore: drop c-kzg fork * test: update tests from Geth See: <ethereum/go-ethereum#28026> * chore: revert `is_create` change * chore: fmt toml * chore: unnecessary import * remove unsafe from fake_exponential * Remove kzg global settings, and move it to CfgEnv * enable kzg only in std. main README updated * fmt and clippy * Update README.md Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * nits and docs * disable exception eip4844 tests, small refactor * revert back last commit refactor --------- Co-authored-by: rakita <dragan0rakita@gmail.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: Waylon Jepsen <57912727+0xJepsen@users.noreply.github.com>
tonyke-bot
pushed a commit
to fuzzland/revm
that referenced
this pull request
Sep 19, 2023
* feat: point evaluation precompile * feat: BLOBHASH opcode * refactor: revme runner * renames * export global kzg settings * feat: include kzg settings bytes with `include_bytes!` * build.rs: remove second option, update docs * revme: remove unused files and dead code * feat: implement remaining block and tx env fields * Add tests for helper functions, update constants * Add EIP-4844 EF tests to CI, skip outdated ones * chore: make skip_test more readable * Fix tests * Fix fmt * Fix lints, review * fix: validate new tx, block fields; add to balance check * Restore `load_access_list` * chore: drop c-kzg fork * test: update tests from Geth See: <ethereum/go-ethereum#28026> * chore: revert `is_create` change * chore: fmt toml * chore: unnecessary import * remove unsafe from fake_exponential * Remove kzg global settings, and move it to CfgEnv * enable kzg only in std. main README updated * fmt and clippy * Update README.md Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * nits and docs * disable exception eip4844 tests, small refactor * revert back last commit refactor --------- Co-authored-by: rakita <dragan0rakita@gmail.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: Waylon Jepsen <57912727+0xJepsen@users.noreply.github.com>
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
On ACD 163, it was agreed to bump the target and max blob values from `2/4` to `3/6` for future devnets until we could decide on final mainnet number. This change contains said update, making master pass all the hive tests. The final decision for mainnet cancun is still to be made. --------- Co-authored-by: Felix Lange <fjl@twurst.com>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit d629692.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit d629692.
rising9719
pushed a commit
to rising9719/revm-v-rust
that referenced
this pull request
Oct 25, 2024
* feat: point evaluation precompile * feat: BLOBHASH opcode * refactor: revme runner * renames * export global kzg settings * feat: include kzg settings bytes with `include_bytes!` * build.rs: remove second option, update docs * revme: remove unused files and dead code * feat: implement remaining block and tx env fields * Add tests for helper functions, update constants * Add EIP-4844 EF tests to CI, skip outdated ones * chore: make skip_test more readable * Fix tests * Fix fmt * Fix lints, review * fix: validate new tx, block fields; add to balance check * Restore `load_access_list` * chore: drop c-kzg fork * test: update tests from Geth See: <ethereum/go-ethereum#28026> * chore: revert `is_create` change * chore: fmt toml * chore: unnecessary import * remove unsafe from fake_exponential * Remove kzg global settings, and move it to CfgEnv * enable kzg only in std. main README updated * fmt and clippy * Update README.md Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * nits and docs * disable exception eip4844 tests, small refactor * revert back last commit refactor --------- Co-authored-by: rakita <dragan0rakita@gmail.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: Waylon Jepsen <57912727+0xJepsen@users.noreply.github.com>
migramirez2
pushed a commit
to migramirez2/Revm
that referenced
this pull request
Nov 5, 2024
* feat: point evaluation precompile * feat: BLOBHASH opcode * refactor: revme runner * renames * export global kzg settings * feat: include kzg settings bytes with `include_bytes!` * build.rs: remove second option, update docs * revme: remove unused files and dead code * feat: implement remaining block and tx env fields * Add tests for helper functions, update constants * Add EIP-4844 EF tests to CI, skip outdated ones * chore: make skip_test more readable * Fix tests * Fix fmt * Fix lints, review * fix: validate new tx, block fields; add to balance check * Restore `load_access_list` * chore: drop c-kzg fork * test: update tests from Geth See: <ethereum/go-ethereum#28026> * chore: revert `is_create` change * chore: fmt toml * chore: unnecessary import * remove unsafe from fake_exponential * Remove kzg global settings, and move it to CfgEnv * enable kzg only in std. main README updated * fmt and clippy * Update README.md Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * nits and docs * disable exception eip4844 tests, small refactor * revert back last commit refactor --------- Co-authored-by: rakita <dragan0rakita@gmail.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: Waylon Jepsen <57912727+0xJepsen@users.noreply.github.com>
0xsjn
pushed a commit
to 0xsjn/rEVM
that referenced
this pull request
Apr 29, 2025
* feat: point evaluation precompile * feat: BLOBHASH opcode * refactor: revme runner * renames * export global kzg settings * feat: include kzg settings bytes with `include_bytes!` * build.rs: remove second option, update docs * revme: remove unused files and dead code * feat: implement remaining block and tx env fields * Add tests for helper functions, update constants * Add EIP-4844 EF tests to CI, skip outdated ones * chore: make skip_test more readable * Fix tests * Fix fmt * Fix lints, review * fix: validate new tx, block fields; add to balance check * Restore `load_access_list` * chore: drop c-kzg fork * test: update tests from Geth See: <ethereum/go-ethereum#28026> * chore: revert `is_create` change * chore: fmt toml * chore: unnecessary import * remove unsafe from fake_exponential * Remove kzg global settings, and move it to CfgEnv * enable kzg only in std. main README updated * fmt and clippy * Update README.md Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * nits and docs * disable exception eip4844 tests, small refactor * revert back last commit refactor --------- Co-authored-by: rakita <dragan0rakita@gmail.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: Waylon Jepsen <57912727+0xJepsen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back in ACD 163 we agreed to bump the target and max blob values from 2/4 to 3/6 for future devnets until we could decide on final mainnet number. I'm updating it here so that we can get master passing all the hive tests. The final decision is still to be made.