Skip to content

ethclient/gethclient: testcase for createAccessList, make tabledriven #30194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
holiman merged 4 commits into from
Nov 8, 2024
Merged

ethclient/gethclient: testcase for createAccessList, make tabledriven #30194

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1280d75
Add testcase for createAccessList when gasPrice is less than baseFee …
SangIlMo Jul 20, 2024
3e190e9
Add testcode for gasPrice is not specified
SangIlMo Jul 23, 2024
675bd3d
Fix testcode (not related error)
SangIlMo Jul 24, 2024
3262033
ethclient/gethclient: make test tabledriven
holiman Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add testcase for createAccessList when gasPrice is less than baseFee … 
…(default 875M)
  • Loading branch information
@SangIlMo @holiman
SangIlMo authored and holiman committed Nov 8, 2024
commit 1280d75987fb59d9eee385c357871d5150155c3c
23 changes: 23 additions & 0 deletions ethclient/gethclient/gethclient_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"bytes"
"context"
"encoding/json"
"errors"
"math/big"
"testing"

Expand Down Expand Up @@ -214,6 +215,28 @@ func testAccessList(t *testing.T, client *rpc.Client) {
if (*al)[0].StorageKeys[0] != common.HexToHash("0x0000000000000000000000000000000000000000000000000000000000000081") {
t.Fatalf("unexpected storage key: %v", (*al)[0].StorageKeys[0])
}

// error when gasPrice is less than baseFee
msg = ethereum.CallMsg{
From: testAddr,
To: &common.Address{},
Gas: 21000,
GasPrice: big.NewInt(1), // less than baseFee
Value: big.NewInt(1),
}
al, gas, vmErr, err = ec.CreateAccessList(context.Background(), msg)
if errors.Is(err, core.ErrBlobFeeCapTooLow) {
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it, you are waiting for a specific error here, right?
Why are you checking for BlobFeeCap too low, which has nothing to do with the basefeecap?

Copy link
Contributor Author

@SangIlMo SangIlMo Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I just fix this code. (ErrFeeCapTooLow)

One thing is the err at this code, cannot be unwrapped because it was from RPC API response format. So I choose strings.Contains to get the error contains the ErrFeeCapTooLow.

t.Fatalf("unexpected error: %v", err)
}
if vmErr != "" {
t.Fatalf("unexpected vm error: %v", vmErr)
}
if gas != 0 {
t.Fatalf("unexpected gas used: %v", gas)
}
if al != nil {
t.Fatalf("unexpected accesslist: %v", len(*al))
}
}

func testGetProof(t *testing.T, client *rpc.Client, addr common.Address) {
Expand Down