Skip to content

Conversation

aodhgan
Copy link

@aodhgan aodhgan commented Oct 2, 2025

New RPC method eth_sendRawTransactionSync(rawTx, timeoutMs?) that submits a signed tx and blocks until a receipt is available or a timeout elapses.

Two CLI flags to tune server-side limits:

--rpc.txsync.default (default wait window)

--rpc.txsync.max (upper bound; requests are clamped)

Creates a SubscribeTransactionReceipts subscription to monitor and extract desired receipts.

Success/timeout unit tests added.

closes #32094

@aodhgan aodhgan changed the title feat(rpc): add eth_SendRawTransactionSync internal/ethapi: add eth_SendRawTransactionSync Oct 2, 2025
@fjl fjl assigned s1na Oct 7, 2025
@s1na s1na removed the status:triage label Oct 8, 2025
@s1na
Copy link
Contributor

s1na commented Oct 8, 2025

We can do a slight refactor with this PR merged: #32697 (comment)

@s1na
Copy link
Contributor

s1na commented Oct 9, 2025

We can do a slight refactor with this PR merged: #32697 (comment)

This PR was merged ^

@aodhgan aodhgan force-pushed the ag/feat/add-ethsendRawTransactionSync branch from 0daa396 to 3a3c46a Compare October 9, 2025 19:23
@Sahil-4555
Copy link

@s1na @gawnieg
According to the EIP-7966, if a transaction is not ready to be processed, the handler should return error code 5 along with an error message. I checked the SubmitTransaction function but didn’t see this implemented—should it be added here or handling elsewhere?

@ethereumorg092-arch ethereumorg092-arch mentioned this pull request Oct 10, 2025
@aodhgan
Copy link
Author

aodhgan commented Oct 10, 2025

@s1na @gawnieg According to the EIP-7966, if a transaction is not ready to be processed, the handler should return error code 5 along with an error message. I checked the SubmitTransaction function but didn’t see this implemented—should it be added here or handling elsewhere?

The given examples (missing nonce or insufficient funds) are already covered by their own more granular codes (https://github.com/aodhgan/go-ethereum/blob/ag/feat/add-ethsendRawTransactionSync/internal/ethapi/errors.go#L102). There is an option to coalesce these into the new error code 5 but dont see much value? (Also considering the EIP says SHOULD (vs MUST)). The "node not ready to accept new transactions" seems to require a deeper set of changes? wdyt @s1na?

Receipt *types.Receipt
Transaction *types.Transaction
}
type ReceiptWithTx = ethapi.ReceiptWithTx
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to avoid circular dependency

@Sahil-4555
Copy link

The given examples (missing nonce or insufficient funds) are already covered by their own more granular codes (https://github.com/aodhgan/go-ethereum/blob/ag/feat/add-ethsendRawTransactionSync/internal/ethapi/errors.go#L102). There is an option to coalesce these into the new error code 5 but dont see much value? (Also considering the EIP says SHOULD (vs MUST)). The "node not ready to accept new transactions" seems to require a deeper set of changes? wdyt @s1na?

Got it, that makes sense. Since the EIP says SHOULD and not MUST, it’s optional. I just wanted to check if we plan to follow that or keep using the current detailed error codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EIP 7966 - eth_sendRawTransactionSync

5 participants