Skip to content
This repository was archived by the owner on Oct 6, 2025. It is now read-only.

Conversation

@CarlBeek
Copy link
Collaborator

No description provided.

maxwellt and others added 16 commits November 4, 2020 02:35
This feels to me like it would be more intuitive behavior; the `from_json` behaves the same way for Keystore and KeystoreCrypto, and it exposes a way for people to use the library with json that is not saved in a file anywhere.
Proposed tweak to from_json and from_file
Add Prymont + Add `eth2_network_name` field to deposit_data*.json file
@CarlBeek CarlBeek requested a review from hwwhww November 17, 2020 16:23
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarlBeek CarlBeek merged commit ed5a6d3 into master Nov 17, 2020
sangheraio pushed a commit to earthwallet/earth-wallet-cli that referenced this pull request Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants