Skip to content
This repository was archived by the owner on Oct 6, 2025. It is now read-only.

Conversation

@jeremie-H
Copy link
Contributor

Hello there,

It's just a little fix in french confirmation prompt.
I think there was a copy/paste, but it was weird when using in french and ask for password when it should ask to confirm for index

@wackerow
Copy link
Member

Thanks @jeremie-H! This LGTM.. @lukassim I don't see this string in Crowdin (and I see some old ones in there that are no longer used)... should we upload these to Crowdin again to double check everything is correct?

@CarlBeek CarlBeek changed the base branch from master to dev July 31, 2022 12:47
@CarlBeek
Copy link
Collaborator

Hey @jeremie-H, you are correct that is a mistake in the transaltion, thank you. Could you rebase off of the dev branch (as that is the staging branch) please. That was I can get it merged ASAP. :)

@wackerow, yes we're probably overdue for annother round of crowdin cleanup.

@jeremie-H
Copy link
Contributor Author

is it better like that ? :)

Copy link
Collaborator

@CarlBeek CarlBeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks @jeremie-H!

@CarlBeek CarlBeek merged commit 947cad8 into ethereum:dev Aug 1, 2022
@CarlBeek CarlBeek mentioned this pull request Aug 1, 2022
sangheraio pushed a commit to earthwallet/earth-wallet-cli that referenced this pull request Aug 3, 2023
…-index

🌐 fix fr translation for starting index
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants