-
Notifications
You must be signed in to change notification settings - Fork 365
Description
EIP7610 has been merged ethereum/EIPs#8161, while there are some tests are outdated because of it.
stSStoreTest/InitCollision.json
It tests a scenario that: account already has storage X. create -> in init code change that account's storage -> 0 -> change it to X again . As the contract deployment will be rejected if the destination has non-empty storage, therefore, this test should be removed or updated.
stRevertTest/RevertInCreateInInit.json, stCreate2/RevertInCreateInInitCreate2
This test involves a scenario that the destination of contract deployment has non-empty storage. According to EIP7610, the whole deployment should be rejected. This test should be removed.
stCreate2/create2collisionStorage
It tests a scenario that: create2 generates an account that already exists and has storage != 0. This test should be removed or updated.
stExtCodeHash/dynamicAccountOverwriteEmpty
It tests a scenario that: EXTCODEHASH of empty account, then CREATE or CREATE2 over it, EXTCODEHASH again. This should check that code hash cache is correctly updated during the transaction.
Unfortunately, the target of EXTCODEHASH has a non-empty storage and it's not eligible for re-deployment. This test should be updated.