Skip to content

Optional cast of all metrics to lower case #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vchekan wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Optional cast of all metrics to lower case #103

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76e0b8a
Make metrics low-case by default
vchekan Jul 15, 2015
bbac7c4
Merge remote-tracking branch 'ntent/dev' into dev
Jul 16, 2015
2597f1a
Make default metrics case backward-compatible (do not force lower case).
vchekan Sep 17, 2015
867da21
Merge remote-tracking branch 'origin/dev' into dev
vchekan Sep 17, 2015
dae9ce5
Ntent-specific package names.
vchekan Sep 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make default metrics case backward-compatible (do not force lower case).
  • Loading branch information
@vchekan
vchekan committed Sep 17, 2015
commit 2597f1accf27d613a7d47c3b06fff629bade4966
6 changes: 3 additions & 3 deletions Src/Metrics/Graphite/GraphiteExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace Metrics
{
public static class GraphiteExtensions
{
public static MetricsReports WithGraphite(this MetricsReports reports, Uri graphiteUri, TimeSpan interval, bool keysToLowercase = true)
public static MetricsReports WithGraphite(this MetricsReports reports, Uri graphiteUri, TimeSpan interval, bool keysToLowercase = false)
{
if (graphiteUri.Scheme.ToLowerInvariant() == "net.tcp")
{
Expand All @@ -31,12 +31,12 @@ public static MetricsReports WithPickledGraphite(this MetricsReports reports, st
return reports.WithGraphite(new PickleGraphiteSender(host, port, batchSize, keysToLowercase), interval);
}

public static MetricsReports WithTCPGraphite(this MetricsReports reports, string host, int port, TimeSpan interval, bool keysToLowercase = true)
public static MetricsReports WithTCPGraphite(this MetricsReports reports, string host, int port, TimeSpan interval, bool keysToLowercase = false)
{
return reports.WithGraphite(new TcpGraphiteSender(host, port, keysToLowercase), interval);
}

public static MetricsReports WithUDPGraphite(this MetricsReports reports, string host, int port, TimeSpan interval, bool keysToLowercase = true)
public static MetricsReports WithUDPGraphite(this MetricsReports reports, string host, int port, TimeSpan interval, bool keysToLowercase = false)
{
return reports.WithGraphite(new UdpGraphiteSender(host, port, keysToLowercase), interval);
}
Expand Down
2 changes: 1 addition & 1 deletion Src/Metrics/Graphite/PickleGraphiteSender.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public sealed class PickleGraphiteSender : GraphiteSender
private PickleJar jar = new PickleJar();


public PickleGraphiteSender(string host, int port, int batchSize = DefaultPickleJarSize, bool keysToLowercase = true)
public PickleGraphiteSender(string host, int port, int batchSize = DefaultPickleJarSize, bool keysToLowercase = false)
{
this.host = host;
this.port = port;
Expand Down