Skip to content

Conversation

Gerschtli
Copy link
Contributor

I have added the tests directory and the tox.ini in MANIFEST.in to be able to run the tests after installing the source via PyPi to check if the installation ran successfully.

Motivation: NixOS/nixpkgs#45871 (comment)

@coveralls
Copy link

coveralls commented Sep 1, 2018

Coverage Status

Coverage remained the same at 77.751% when pulling e5cf10f on Gerschtli:tests-manifest into b2b69b3 on ets-labs:develop.

@rmk135 rmk135 self-assigned this Sep 1, 2018
@rmk135
Copy link
Member

rmk135 commented Sep 1, 2018

Hi @Gerschtli ,

Thank you very much for your contribution! It definitely makes sense and looks good to me.

Can I, please, ask you to change source branch to "develop"?

Thanks,
Roman

@Gerschtli Gerschtli changed the base branch from master to develop September 1, 2018 23:05
@Gerschtli
Copy link
Contributor Author

Done! Thank you!

@rmk135 rmk135 merged commit bd855ac into ets-labs:develop Sep 2, 2018
@rmk135
Copy link
Member

rmk135 commented Sep 2, 2018

Merged and released to PyPI as version 3.13.2 .

@Gerschtli Gerschtli deleted the tests-manifest branch September 18, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants