Feat/semantic search #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // Helper function to escape markdown special characters in table cells | ||
| function escapeMarkdown(text: string): string { | ||
| return text.replace(/\|/g, "\\|").replace(/\n/g, " "); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 months ago
To fix the problem, we need to ensure that backslashes are also escaped in the escapeMarkdown function. This can be done by adding an additional replace call to handle backslashes. The best way to fix this without changing existing functionality is to modify the escapeMarkdown function to include a regular expression that escapes backslashes before escaping other characters.
Suggested changeset
1
src/semantic_search.ts
| @@ -97,3 +97,3 @@ | ||
| function escapeMarkdown(text: string): string { | ||
| return text.replace(/\|/g, "\\|").replace(/\n/g, " "); | ||
| return text.replace(/\\/g, "\\\\").replace(/\|/g, "\\|").replace(/\n/g, " "); | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.