fix: otlp json encoding #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression introduced in commit evanderkoogh@bd0a46a after api change in open-telemetry/opentelemetry-js#4220
evanderkoogh
approved these changes
Aug 22, 2024
Owner
evanderkoogh
left a comment
evanderkoogh
left a comment
There was a problem hiding this comment.
Thanks! I was about to jump into this to debug it. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced in commit bd0a46a after api change in open-telemetry/opentelemetry-js#4220
Fixes # [insert GH issue number(s)].
What this PR solves / how to test:
Update of opentelemetry api replaced boolean parameter useHex with options object. Without this object, it defaults to parameters
{ useHex: false, useLongBits: true }which cannot be ingested by otel collector.Tested manually by comparing data sent to local instance.