Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Decode the _x<4 hex chars>_ escape notation in shared strings
  • Loading branch information
papandreou committed Jun 4, 2018
commit a35b976f9473fa9b146af386153309ab8a4770a6
4 changes: 3 additions & 1 deletion lib/xlsx/xform/strings/text-xform.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ utils.inherits(TextXform, BaseXform, {
},

get model() {
return this._text.join('');
return this._text.join('').replace(/_x([0-9A-F]{4})_/g, function($0, $1) {
return String.fromCharCode(parseInt($1, 16));
});
},

parseOpen: function(node) {
Expand Down
Binary file not shown.
16 changes: 16 additions & 0 deletions spec/integration/workbook-xlsx-reader.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,4 +127,20 @@ describe('WorkbookReader', function() {
});
});
});

describe('with a spreadsheet that contains a shared string with an escaped underscore', function() {
before(function() {
var testContext = this;
var workbook = new Excel.Workbook();
return workbook.xlsx.read(fs.createReadStream('./spec/integration/data/shared_string_with_escape.xlsx'))
.then(function() {
testContext.worksheet = workbook.getWorksheet();
});
});

it('should decode the underscore', function() {
const cell = this.worksheet.getCell('A1');
expect(cell.value).to.equal('_x000D_');
});
});
});