Skip to content

Conversation

@windauer
Copy link

Changed pom.xml to 1.7.0-SNAPSHOT in preparation to release a version 1.7.0 which never got release afaik. I'm perfectly fine with another version number as well but 1.7 is certainly not the one we want to start of with.

@windauer windauer marked this pull request as draft June 27, 2021 19:44
@windauer windauer marked this pull request as ready for review June 27, 2021 19:46
@joewiz
Copy link
Member

joewiz commented Jun 28, 2021

I'd suggest incrementing the version to 1.7.1-SNAPSHOT. According to semver sorting rules, 1.7.0-SNAPSHOT < 1.7. The new development and release versions should be >1.7, even if the code hasn't changed—if only to reflect the change in organization and commitment to semver, use of central maven repositories, etc.

@windauer
Copy link
Author

as @adamretter already started cleaning up the repo this PR can be closed. Thanks you @adamretter

@windauer windauer closed this Jun 28, 2021
@adamretter
Copy link
Member

@joewiz @windauer 1.8.0 was just released to Central.

@adamretter
Copy link
Member

The semantic versioning was also mentioned previously - #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants