Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: extract code for compiling equal operator
  • Loading branch information
zhuliquan committed Mar 27, 2024
commit 715e2b4be2d839e2bfb550b144074cf3952ecac3
48 changes: 24 additions & 24 deletions compiler/compiler.go
Original file line number Diff line number Diff line change
Expand Up @@ -395,34 +395,12 @@ func (c *compiler) UnaryNode(node *ast.UnaryNode) {
}

func (c *compiler) BinaryNode(node *ast.BinaryNode) {
l := kind(node.Left)
r := kind(node.Right)

leftIsSimple := isSimpleType(node.Left)
rightIsSimple := isSimpleType(node.Right)
leftAndRightAreSimple := leftIsSimple && rightIsSimple

switch node.Operator {
case "==":
c.compile(node.Left)
c.derefInNeeded(node.Left)
c.compile(node.Right)
c.derefInNeeded(node.Right)

if l == r && l == reflect.Int && leftAndRightAreSimple {
c.emit(OpEqualInt)
} else if l == r && l == reflect.String && leftAndRightAreSimple {
c.emit(OpEqualString)
} else {
c.emit(OpEqual)
}
c.equalBinaryNode(node)

case "!=":
c.compile(node.Left)
c.derefInNeeded(node.Left)
c.compile(node.Right)
c.derefInNeeded(node.Right)
c.emit(OpEqual)
c.equalBinaryNode(node)
c.emit(OpNot)

case "or", "||":
Expand Down Expand Up @@ -580,6 +558,28 @@ func (c *compiler) BinaryNode(node *ast.BinaryNode) {
}
}

func (c *compiler) equalBinaryNode(node *ast.BinaryNode) {
l := kind(node.Left)
r := kind(node.Right)

leftIsSimple := isSimpleType(node.Left)
rightIsSimple := isSimpleType(node.Right)
leftAndRightAreSimple := leftIsSimple && rightIsSimple

c.compile(node.Left)
c.derefInNeeded(node.Left)
c.compile(node.Right)
c.derefInNeeded(node.Right)

if l == r && l == reflect.Int && leftAndRightAreSimple {
c.emit(OpEqualInt)
} else if l == r && l == reflect.String && leftAndRightAreSimple {
c.emit(OpEqualString)
} else {
c.emit(OpEqual)
}
}

func isSimpleType(node ast.Node) bool {
if node == nil {
return false
Expand Down