Skip to content

Use headersSent instead of _header #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 9, 2024
Merged

Use headersSent instead of _header #129

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
24a6740
fix: change usage of _header to headersSernt
Jan 10, 2018
2a79feb
Merge branch 'master' into change/use_headersSent_instead_of__header
bjohansebas Nov 3, 2024
1427161
improve logic
bjohansebas Nov 3, 2024
3cac105
Merge branch 'master' of github.com:expressjs/compression into change…
bjohansebas Nov 3, 2024
9c96376
update history
bjohansebas Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve logic
  • Loading branch information
@bjohansebas
bjohansebas committed Nov 3, 2024
commit 14271613dedd9ab714d294a1cb180cea5101ded2
18 changes: 16 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function compression (options) {
return false
}

if (!this.headersSent) {
if (!headersSent(res)) {
this._implicitHeader()
}

Expand All @@ -94,7 +94,7 @@ function compression (options) {
return false
}

if (!this.headersSent) {
if (!headersSent(res)) {
// estimate the length
if (!this.getHeader('Content-Length')) {
length = chunkLength(chunk, encoding)
Expand Down Expand Up @@ -281,3 +281,17 @@ function toBuffer (chunk, encoding) {
? Buffer.from(chunk, encoding)
: chunk
}

/**
* Determine if the response headers have been sent.
*
* @param {object} res
* @returns {boolean}
* @private
*/

function headersSent (res) {
return typeof res.headersSent !== 'boolean'
? Boolean(res._header)
: res.headersSent
}