Skip to content

Conversation

@rritik772
Copy link

@rritik772 rritik772 commented Jul 5, 2024

[X] Ran tests
[X] Ran linter

Related #5714

Context: #5746 (comment)

[X] Ran tests
[X] Ran linter

Related #5714
@UlisesGascon UlisesGascon self-assigned this Jul 5, 2024
@UlisesGascon
Copy link
Member

This PR can be merged after #5595

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rritik772 for doing the PR for 5.x!

@rritik772 rritik772 closed this by deleting the head repository Jul 9, 2024
@wesleytodd
Copy link
Member

Hey, just wondering what happened here. I see the approval but then deleted. Do we need to open a new PR once #5595 is merged?

@rritik772
Copy link
Author

Should I resubmit the pull request, some mistake happened from my side.

@wesleytodd
Copy link
Member

Ah, ok no worries. Um I think we would want this update, so if you are willing and able to re-open it I think that is best.

@UlisesGascon
Copy link
Member

You might be able to restore the fork (guide) and then re-open the PR

@rritik772 rritik772 mentioned this pull request Jul 11, 2024
@rritik772
Copy link
Author

Hey, I have open a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants