Skip to content

Fix: Add type validation for sendStatus to prevent BigInt serialization error (#6756) #6758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vedant224 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Add type validation for sendStatus to prevent BigInt serialization error (#6756) #6758

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f48ee1c
Fix: Add type validation for sendStatus to prevent BigInt serializati…
Vedant224 Sep 13, 2025
5338f2c
fix: prevent BigInt crash and centralize validation in res.status
Vedant224 Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/response.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,9 @@ res.jsonp = function jsonp(obj) {
*/

res.sendStatus = function sendStatus(statusCode) {
if (typeof statusCode !== 'number') {
throw new TypeError('Invalid status code: ' + statusCode);
Copy link
Contributor

@shivarm shivarm Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new TypeError('Invalid status code: ' + statusCode);
throw new TypeError(`statusCode must be a valid number to res.sendStatus`);

I think it seems consistent

Copy link
Member

@bjohansebas bjohansebas Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

}
Copy link
Member

@wesleytodd wesleytodd Dec 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @jonchurch, move this to res.status, but throwing for BigInt is the right way to go.

var body = statuses.message[statusCode] || String(statusCode)

this.status(statusCode);
Expand Down
12 changes: 12 additions & 0 deletions test/res.sendStatus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,17 @@ describe('res', function () {
.get('/')
.expect(500, /TypeError: Invalid status code/, done)
})

it('should raise error for BigInt status code', function (done) {
var app = express()

app.use(function (req, res) {
res.sendStatus(200n)
})

request(app)
.get('/')
.expect(500, /TypeError.*Invalid status code/, done)
})
Copy link
Member

@wesleytodd wesleytodd Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will need to move to res.status.js after the other change.

})
})
Loading