Skip to content

Conversation

@yunnysunny
Copy link

No description provided.

@dougwilson
Copy link
Contributor

Hello, ans thank you for your pull request. It looks like this adds an option to this module that, when set, modifies the global Node.js environment.

Unfortunately global modification is not something we would accept as a feature to this module. But the good news is that since you are modifying the global environment, there is no need to add it to this module: simply make the modification in your code or even publish it to npm as it's own module to use.

@dougwilson dougwilson closed this Jun 30, 2022
@dougwilson dougwilson added the pr label Jun 30, 2022
@yunnysunny
Copy link
Author

It may be better to mention the solution in our document.

@lamweili
Copy link

lamweili commented Aug 2, 2022

Would PR #908 be a better solution?
It replaces the undocumented res._implicitHeader with its implementation and as a by-product, also brings HTTP2 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants