Add Logo blocks in the headers #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you also adjust this here (menu/social spacing):
|
Contributor
Author
|
Just for the information: The spacing issue appears when the Gutenberg plugin is active. I think due to step spacing. For that, we need to update the theme.json too. |
Contributor
Author
This spacing issue is related to Gutenberg V14.2.0 because CSS for the gap (Block Spacing) is not rendering properly. This issue only appears in the Site Editor. If we set custom spacing in numeric, CSS renders fine. I think it's due to Gutenberg V14.2.0 switched to using numbers: WordPress/gutenberg#44247
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: https://github.com/extendify/user-research/issues/6
This PR adds the logo to the header-title-nav-button.html and header-title-social-nav.html headers.