Skip to content

Github Action Cache should be unique for all pull requests #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fusesource-ci merged 1 commit into from
Nov 4, 2020
Merged

Github Action Cache should be unique for all pull requests #2589

fusesource-ci merged 1 commit into from
Nov 4, 2020

Conversation

@rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Nov 4, 2020

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia mentioned this pull request Nov 4, 2020
Merged
4 tasks
@iocanel iocanel self-requested a review November 4, 2020 09:25
iocanel
iocanel reviewed Nov 4, 2020
View reviewed changes
Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely better than we currently have, however this won't completely solve the issue. If a pull request is modified its still possible to use stale artifacts.

@iocanel
Copy link
Member

iocanel commented Nov 4, 2020

This is definitely better than we currently have, however this won't completely solve the issue. If a pull request is modified its still possible to use stale artifacts.

So maybe we can use the HEAD sha instead?

@rohanKanojia rohanKanojia force-pushed the pr/maven-cache-unique branch from 441f187 to 18fd013 Compare November 4, 2020 09:37
@rohanKanojia rohanKanojia marked this pull request as ready for review November 4, 2020 10:42
@manusa manusa requested a review from iocanel November 4, 2020 10:44
@rohanKanojia rohanKanojia force-pushed the pr/maven-cache-unique branch from 18fd013 to 78de158 Compare November 4, 2020 10:50
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_272) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11.
Read more here

@manusa
Copy link
Member

manusa commented Nov 4, 2020

[merge]

1 similar comment
@rohanKanojia
Copy link
Member Author

rohanKanojia commented Nov 4, 2020

[merge]

@fusesource-ci fusesource-ci merged commit 3ae9b0f into fabric8io:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iocanel iocanel iocanel approved these changes

@manusa manusa manusa approved these changes

+1 more reviewer

@oscerd oscerd oscerd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rohanKanojia @iocanel @manusa @oscerd @fusesource-ci