Skip to content

Enable the CacheLibWrapper class as a RocksDB Plugin #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Enable the CacheLibWrapper class as a RocksDB Plugin #184

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
00c775a
First pass at adding Cachelib as Pluggable Secondary Cache
mrambacher Nov 13, 2022
fea3f81
Next pass at Cachelib/Rocks integration
mrambacher Nov 29, 2022
6130377
Add namespace
mrambacher Nov 29, 2022
8392fb2
Attempt to fix test to build
mrambacher Nov 29, 2022
7f3b1a1
Another build change
mrambacher Nov 29, 2022
ec1186f
Next pass at CacheLib as a SecondaryCache
mrambacher Dec 5, 2022
143ac0d
Fix bad var names
mrambacher Dec 5, 2022
d825c15
Fix test
mrambacher Dec 5, 2022
75a540c
Cleanup tests
mrambacher Dec 5, 2022
28a8ae3
Add README, fix test issue
mrambacher Dec 23, 2022
52e2d8e
Fix typos
mrambacher Dec 23, 2022
7e62abf
Merge remote-tracking branch 'upstream/main' into CachelibRocksDB
mrambacher Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@mrambacher
mrambacher committed Dec 5, 2022
commit d825c15aba0001dba4b9b36fe303d1e7fd2b16c6
19 changes: 10 additions & 9 deletions cachelib/adaptor/rocks_secondary_cache/tests/CachelibWrapperTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/

#include "plugin/cachelib/CachelibWrapper.h"
#include "rocksdb/convenience.h"
#include "cachelib/common/Utils.h"
#include "test_util/testharness.h"

Expand Down Expand Up @@ -563,38 +564,38 @@ TEST_F(CachelibWrapperTest, LargeItemTest) {

#ifndef ROCKSDB_LITE
TEST_F(CachelibWrapperTest, CreateFromString) {
ROCKSDB::NAMESPACE::ConfigOptions opts;
opts.invoke_prepare_options = true;
ROCKSDB_NAMESPACE::ConfigOptions opts;
opts.invoke_prepare_options = false;
std::shared_ptr<ROCKSDB_NAMESPACE::SecondaryCache> scache;
std::string props = "cachename=foo;"
"filename=bar;"
"size=1000000;"
"size=1048576;"
"block_size=8192;"
"region_size=4096;"
"policy=unknown;"
"probablity=0.50;"
"max_write_rate=1024;"
"admission_write_rate=2048;"
"volatile_size=2000000;"
"volatile_size=524288;"
"bucket_power=48;"
"lock_power=24;";

ASSERT_EQ(ROCKSDB_NAMESPACE::SecondaryCache::CreateFromString(opts,
props + "id=" + RocksCachelibWrapper::kClassName() +
props + "id=" + RocksCachelibWrapper::kClassName(),
&scache),
ROCKSDB_NAMESPACE::Status::OK());
auto rco = scache->GetOptions<RocksCachelibOptions>();
ASSERT_NE(rco, nullptr);
ASSERT_STREQ(rco->cacheName, "foo");
ASSERT_STREQ(rco->fileName, "bar");
ASSERT_EQ(rco->size, 1000000);
ASSERT_EQ(rco->cacheName, "foo");
ASSERT_EQ(rco->fileName, "bar");
ASSERT_EQ(rco->size, 1048576);
ASSERT_EQ(rco->blockSize, 8192);
ASSERT_EQ(rco->regionSize, 4096);
ASSERT_EQ(rco->admProbability, 0.5);
ASSERT_EQ(rco->admPolicy, "unknown");
ASSERT_EQ(rco->maxWriteRate, 1024);
ASSERT_EQ(rco->admissionWriteRate, 2048);
ASSERT_EQ(rco->volatileSize, 2000000);
ASSERT_EQ(rco->volatileSize, 524288;
ASSERT_EQ(rco->bktPower, 48);
ASSERT_EQ(rco->lockPower, 24);

Expand Down