Skip to content

Add support for dynamic import & disable require.ensure #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 15, 2017
Merged

Add support for dynamic import & disable require.ensure #1538

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7c08989
Disable require.ensure
Timer Feb 12, 2017
adcc6ea
Replace require.ensure with import
Timer Feb 12, 2017
0055e79
Add babel plugin for parsing import()
Timer Feb 12, 2017
658ce80
Get the default
Timer Feb 12, 2017
a44f50d
Upgrade babel-eslint to support dynamic import
Timer Feb 12, 2017
e5ab837
Fix dep
Timer Feb 12, 2017
020b8f9
Update deps
Timer Feb 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Disable require.ensure
  • Loading branch information
@Timer
Timer committed Feb 12, 2017
commit 7c089896b928e08fb0b2455287ad8e1fa4acd82a
2 changes: 2 additions & 0 deletions packages/react-scripts/config/webpack.config.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ module.exports = {
// @remove-on-eject-end
module: {
rules: [
// Disable require.ensure as it's not a standard language feature.
{ parser: { requireEnsure: false } },
// First, run the linter.
// It's important to do this before Babel processes the JS.
{
Expand Down
2 changes: 2 additions & 0 deletions packages/react-scripts/config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ module.exports = {
// @remove-on-eject-end
module: {
rules: [
// Disable require.ensure as it's not a standard language feature.
{ parser: { requireEnsure: false } },
// First, run the linter.
// It's important to do this before Babel processes the JS.
{
Expand Down