Skip to content

run npm 5.4.0 in CI #3026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 7, 2017
Merged

run npm 5.4.0 in CI #3026

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26197e7
run npm 5.4.0 in CI
viankakrisna Aug 23, 2017
503223c
run npm cache clean with --force in CI
viankakrisna Aug 29, 2017
9f55eec
use link instead of install
viankakrisna Aug 29, 2017
93649a8
Update e2e-installs.sh
viankakrisna Sep 7, 2017
be460db
Update e2e-kitchensink.sh
viankakrisna Sep 7, 2017
e56ac75
Update e2e-simple.sh
viankakrisna Sep 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
run npm 5.4.0 in CI
  • Loading branch information
@viankakrisna
viankakrisna committed Aug 23, 2017
commit 26197e785d03d4d3c3380004ce5784dee8bbd3ee
4 changes: 2 additions & 2 deletions tasks/e2e-installs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ fi

if hash npm 2>/dev/null
then
# npm 5 is too buggy right now
# npm 5.0-5.3 is too buggy
if [ $(npm -v | head -c 1) -eq 5 ]; then
npm i -g npm@^4.x
npm i -g npm@^5.4.0
fi;
npm cache clean || npm cache verify
fi
Expand Down
8 changes: 4 additions & 4 deletions tasks/e2e-kitchensink.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ fi

if hash npm 2>/dev/null
then
# npm 5 is too buggy right now
# npm 5.0-5.3 is too buggy
if [ $(npm -v | head -c 1) -eq 5 ]; then
npm i -g npm@^4.x
npm i -g npm@^5.4.0
fi;
npm cache clean || npm cache verify
fi
Expand Down Expand Up @@ -163,8 +163,8 @@ npm install test-integrity@^2.0.1
# Enter the app directory
cd "$temp_app_path/test-kitchensink"

# Link to our preset
npm link "$root_path"/packages/babel-preset-react-app
# Install our preset
npm install file:"$root_path"/packages/babel-preset-react-app

# Link to test module
npm link "$temp_module_path/node_modules/test-integrity"
Expand Down
4 changes: 2 additions & 2 deletions tasks/e2e-simple.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@ fi

if hash npm 2>/dev/null
then
# npm 5 is too buggy right now
# npm 5.0-5.3 is too buggy
if [ $(npm -v | head -c 1) -eq 5 ]; then
npm i -g npm@^4.x
npm i -g npm@^5.4.0
fi;
npm cache clean || npm cache verify
fi
Expand Down