Skip to content

Auto-detect running editor on Linux for error overlay #3077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 11, 2017
Merged

Auto-detect running editor on Linux for error overlay #3077

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64a6ed7
Auto-detect running editor on Linux for error overlay
gulderov Sep 6, 2017
992104c
Comments fixed.
gulderov Sep 7, 2017
9456669
List all processes owned by you
gulderov Sep 7, 2017
9197752
Comment rewording
gulderov Sep 11, 2017
e023800
Merge branch 'master' into auto-detect-editor-linux
gulderov Sep 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
List all processes owned by you
  • Loading branch information
@gulderov
gulderov committed Sep 7, 2017
commit 94566696ec7061209784f4327b0b8422861aff50
4 changes: 2 additions & 2 deletions packages/react-dev-utils/launchEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,10 @@ function guessEditor() {
}
} else if (process.platform === 'linux') {
// --no-heading No header line
// -e Select all processes
// x List all processes owned by you
// -o comm Need only names column
const output = child_process
.execSync('ps --no-heading -e -o comm --sort=comm')
.execSync('ps x --no-heading -o comm --sort=comm')
.toString();
const processNames = Object.keys(COMMON_EDITORS_LINUX);
for (let i = 0; i < processNames.length; i++) {
Expand Down