Skip to content

Switch to unix path separators before normalizing path for Windows compatibility #3079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 6, 2017
Merged

Switch to unix path separators before normalizing path for Windows compatibility #3079

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
014fd4d
Switch to unix path separators before normalizing path for Windows co…
Timer Sep 6, 2017
742bace
Add comment for posterity
Timer Sep 6, 2017
8441f95
Revert "Add comment for posterity"
Timer Sep 6, 2017
5be590a
Strictly add comment
Timer Sep 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Strictly add comment
  • Loading branch information
@Timer
Timer committed Sep 6, 2017
commit 5be590a108f9fe5f18eabb7ff916f72f4bae7229
5 changes: 5 additions & 0 deletions packages/react-error-overlay/src/utils/unmapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ async function unmap(
}
let { fileName } = frame;
if (fileName) {
// The web version of this module only provides POSIX support, so Windows
// paths like C:\foo\\baz\..\\bar\ cannot be normalized.
// A simple solution to this is to replace all `\` with `/`, then
// normalize afterwards.
fileName = path.normalize(fileName.replace(/[\\]+/g, '/'));
Copy link
Contributor

@gaearon gaearon Sep 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add a comment for why it helps.

}
if (fileName == null) {
Expand All @@ -64,6 +68,7 @@ async function unmap(
const fN: string = fileName;
const source = map
.getSources()
// Prepare path for normalization; see comment above for reasoning.
.map(s => s.replace(/[\\]+/g, '/'))
.filter(p => {
p = path.normalize(p);
Expand Down