Skip to content

Add click-to-open support for build errors #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 6, 2017
Merged

Add click-to-open support for build errors #3100

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
830c4e9
Implement click-to-open for babel syntax errors in build error overlay
tharakawj Sep 8, 2017
51236e9
Add click-to-open support for lint errors and refactor parser
tharakawj Sep 9, 2017
de8e9b6
Reactor code to reuse open-in-editor functionality in both build and …
tharakawj Sep 9, 2017
5c0cccf
Fix some eslint warnings
tharakawj Sep 10, 2017
88cd256
Add a comment about keeping middleware and dev client in sync
tharakawj Sep 10, 2017
64ef981
Remove es6 features from webpack dev client
tharakawj Sep 10, 2017
8d36cd9
Make open-in-editor functionality to work with new iframe script
tharakawj Oct 4, 2017
a0b3566
Rename `openInEditor` to `editorHandler`
tharakawj Oct 4, 2017
ae18e55
Fix flow errors
tharakawj Oct 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a comment about keeping middleware and dev client in sync
  • Loading branch information
@tharakawj
tharakawj committed Oct 4, 2017
commit 88cd256c60f755380596a4337c16e5f68c372c4e
1 change: 1 addition & 0 deletions packages/react-dev-utils/webpackHotDevClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ ErrorOverlay.listenToOpenInEditor(function OpenInEditor({
fileName,
lineNumber,
}) {
// Keep this sync with errorOverlayMiddleware.js
fetch(
`${launchEditorEndpoint}?fileName=` +
window.encodeURIComponent(fileName) +
Expand Down