Skip to content

Make error overlay to run in the context of the iframe #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 3, 2017
Merged

Make error overlay to run in the context of the iframe #3142

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
92a79f4
Make error overlay to run in the context of the iframe
tharakawj Sep 17, 2017
0a2acf5
Configure webpack to build the entire package
tharakawj Sep 23, 2017
0b48c89
Remove inline raw-loder config
tharakawj Sep 23, 2017
f569f45
Configure watch mode for error-overlay webpack build
tharakawj Sep 23, 2017
a52592f
Add pollyfills to the error-overlay iframe script
tharakawj Sep 23, 2017
483e631
Add header comment
tharakawj Sep 23, 2017
fd248f7
Configure to fail CI on error or warning
tharakawj Sep 24, 2017
7796f54
Suppress flowtype error on importing iframe-bundle
tharakawj Sep 24, 2017
272c491
Change webpack to a dev dependency and pin some versions
tharakawj Sep 25, 2017
4dff32a
Disable webpack cache
tharakawj Oct 3, 2017
57274a4
Update license headers to MIT
tharakawj Oct 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Configure watch mode for error-overlay webpack build
  • Loading branch information
@tharakawj
tharakawj committed Oct 3, 2017
commit f569f45f30ad7b19b8fba530fc250d50021d7cfb
31 changes: 30 additions & 1 deletion packages/react-error-overlay/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ const chalk = require('chalk');
const webpackConfig = require('./webpack.config.js');
const iframeWebpackConfig = require('./webpack.config.iframe.js');
const rimraf = require('rimraf');
const chokidar = require('chokidar');

const args = process.argv.slice(2);
const watchMode = args[0] === '--watch' || args[0] === '-w';

function build(config, name, callback) {
console.log(chalk.cyan('Compiling ' + name));
Expand Down Expand Up @@ -38,13 +42,38 @@ function runBuildSteps() {
build(iframeWebpackConfig, 'iframeScript.js', () => {
build(webpackConfig, 'index.js', () => {
console.log(chalk.bold.green('Compiled successfully!'));
console.log();
console.log();
});
});
}

function setupWatch() {
const watcher = chokidar.watch('./src', {
ignoreInitial: true,
});

watcher.on('change', runBuildSteps);
watcher.on('add', runBuildSteps);

watcher.on('ready', () => {
runBuildSteps();
});

process.on('SIGINT', function() {
watcher.close();
process.exit(0);
});

watcher.on('error', error => {
console.error('Watcher failure', error);
process.exit(1);
});
}

// Clean up lib folder
rimraf('lib/', () => {
console.log('Cleaned up the lib folder.');
console.log();
runBuildSteps();
watchMode ? setupWatch() : runBuildSteps();
});
3 changes: 2 additions & 1 deletion packages/react-error-overlay/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "lib/index.js",
"scripts": {
"prepublishOnly": "npm run build:prod && npm test",
"start": "cross-env NODE_ENV=development node build.js",
"start": "cross-env NODE_ENV=development node build.js --watch",
"test": "flow && cross-env NODE_ENV=test jest",
"build": "cross-env NODE_ENV=development node build.js",
"build:prod": "cross-env NODE_ENV=production node build.js"
Expand Down Expand Up @@ -46,6 +46,7 @@
"babel-eslint": "7.2.3",
"babel-preset-react-app": "^3.0.3",
"chalk": "^2.1.0",
"chokidar": "^1.7.0",
"cross-env": "5.0.5",
"eslint": "4.4.1",
"eslint-config-react-app": "^2.0.1",
Expand Down